[udig-devel] [jira] Created: (UDIG-1373) Exception when editing the style of multiple layers

[Jody Garnett (JIRA)]

Exception when editing the style of multiple layers
---------------------------------------------------

                 Key: UDIG-1373
                 URL: http://jira.codehaus.org/browse/UDIG-1373
             Project: uDIG
          Issue Type: Bug
          Components: style
    Affects Versions: UDIG 1.2.M0
            Reporter: Jody Garnett
            Assignee: Cory Horner


>From email (thanks Maria):
----

In order to reproduce the error, choose a layer, right-click to Change Style, the dialog appears, everything is fine. Close the window.
Afterwards, right-click the Change Style button of another layer, and that's when the conflicts happen. 

{noformat}
!MESSAGE A handler conflict occurred.  This may disable some commands.
!SUBENTRY 1 org.eclipse.ui.workbench 2 0 2008-03-05 16:24:00.174
!MESSAGE Conflict for 'org.eclipse.ui.navigate.backwardHistory':
HandlerActivation(commandId=org.eclipse.ui.navigate.backwardHistory,
        handler=ActionHandler(net.refractions.udig.style.sld.editor.internal.PageHistoryHolder$1 at 1d2822f),
        expression=,sourcePriority=0)
HandlerActivation(commandId=org.eclipse.ui.navigate.backwardHistory,
        handler=ActionHandler(net.refractions.udig.style.sld.editor.internal.PageHistoryHolder$1 at 1610393),
        expression=,sourcePriority=0)
{noformat}

I've debuged, and the conflicts apear in PageHistoryHolder class, within the method registerKeybindings.

So, I decided to cleanup the PageHistoryHolder resources by calling the dispose() method from the FilteredEditorDialog.close() method "if (history!= null ) history.dispose()" and it works fine.

{code}

# FilteredEditorDialog.java
public boolean close() {
                if (history!= null ) history.dispose();
                return super.close();
        } 
{code}


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira