[udig-devel] [jira] Created: (UDIG-1325) setEditFeaturdCommand grabbing the wrong layer (from FeatureEditor)

[Jody Garnett (JIRA)]

setEditFeaturdCommand grabbing the wrong layer (from FeatureEditor)
-------------------------------------------------------------------

                 Key: UDIG-1325
                 URL: http://jira.codehaus.org/browse/UDIG-1325
             Project: uDIG
          Issue Type: Bug
          Components: API project
    Affects Versions: UDIG 1.2.M0
            Reporter: Jody Garnett


The setEditFeatureCommand is doing something a bit crazy... as used by the Apply button in the "countries" editor in tutorials
- it takes the provided Feature
- it makes a fid filter
- it does a query against all the layers to see if any have a count() == 1
- it manages to get false positives

Comments:
- shapefile "hasNext()" is based on their being more data; not based on the Feature passing the filter?
- I don't see the filter check being applied or wrapped around raw shapefile reader
-  There is a crazy check in shapefile datastore code that checks if the filter is an "Id" and if a "fixURL" is non null (no idea what fixURL is for), and if so it changes the Filter to INCLUDES.

Solution? 
- we can do the adaptable thing; check if the feature is Adatable and ask it about its layer (this seems to be accepted practice these days)
- not sure about the shapefile QA issues with FID filters


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira