[udig-devel] [jira] Created: (UDIG-1284) Bug in selection with filter in MapImpl

[Emmanuel AUVINET (JIRA)]

Bug in selection with filter in MapImpl
---------------------------------------

                 Key: UDIG-1284
                 URL: http://jira.codehaus.org/browse/UDIG-1284
             Project: uDIG
          Issue Type: Bug
          Components: map
    Affects Versions: UDIG 1.2
            Reporter: Emmanuel AUVINET
            Assignee: Jesse Eichar
            Priority: Minor


A selection with select( Filter filter, boolean and ) create a bad filter when and == false :
{quote}
public class MapImpl ...{
...
 public void select( Filter filter, boolean and ){
...
_// UDIG 1.1RC10_
 if (!and){
        try{
     LogicFilter logicFilter;
 {color:red} // Replace :
            logicFilter = createFilterFactory.createLogicFilter(oldFilter, target(
            ayer, filter), FilterType.LOGIC_AND);
{color}
 {color:green} // by :
            LogicFilter notFilter=createFilterFactory.createLogicFilter(filter, FilterType.LOGIC_NOT);
            LogicFilter logicFilter = createFilterFactory.createLogicFilter(notFilter,oldFilter, FilterType.LOGIC_AND);
{color}
            layer.setFilter(logicFilter);
       }catch (IllegalFilterException e) {
...
  _// UDIG 1.2_
 if (!and) {
        try {
            LogicFilter logicFilter;
 {color:red}// Replace :
            logicFilter = createFilterFactory.and(oldFilter, target(
                                   layer, filter));
{color}
 {color:green} // by :
      Not notFilter=createFilterFactory.not(filter);
      logicFilter = createFilterFactory.and(oldFilter, target(
                                                   layer, notFilter));
{color}
            layer.setFilter(logicFilter);
       } catch (IllegalFilterException e) {
...
}
...
}
{quote}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira