[udig-devel] 2 issues with temporary fixes are in trunk!!

[Vitali Diatchkov]

Good day/morning!

1) BasicWMSRenderer2.calculateRequestBoundingBox(...) contained wrong
calculations: when the user adds WMS layer to the empty map, the viewport
gets bounding box of the whole layer. This leads to wrong calculations of
BBOX calculation in specified method that in its order leads to wrong
unproportional map image returned by MapServer (wms_wrong.jpg).
temporary quick fix is in trunk. The right map image is wms_right.jpg.


2) BasicFeatureRenderer.validateBounds(..) contains mistaken behavior.
Transforming bounding box from layer CRS to WGS_84 and back violates the
accuracy. This leads to overlapping effect on the map during re-rendering of
the one feature by its bounding box when transparency is used in style (see
validatebounds_error.jpg).
On the image (I highlighted the feature by drawing command) you can easily
see the exact bounding box of the feature that was cleared from buffer
image, but really rendered bounding box is a bit expanded because of wrong
validateBounds(..) method calculations. And because of layer style
transparency (filling) we see that effect of overlapping. The layer CRS is
KKJ (Finland uniform), double transformation looses the accuracy.

Quick temporary fixes are in trunk in these classes. Please check the issues
to get rid of described problems.

Vitali.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: validatebounds_error.gif
Type: image/gif
Size: 11855 bytes
Desc: not available
Url : http://lists.refractions.net/pipermail/udig-devel/attachments/20061024/51eefb35/validatebounds_error-0001.gif
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wms_error.gif
Type: image/gif
Size: 124521 bytes
Desc: not available
Url : http://lists.refractions.net/pipermail/udig-devel/attachments/20061024/51eefb35/wms_error-0001.gif
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wms_right.gif
Type: image/gif
Size: 50096 bytes
Desc: not available
Url : http://lists.refractions.net/pipermail/udig-devel/attachments/20061024/51eefb35/wms_right-0001.gif