[udig-devel] Re: [Geotools-devel] Filter is not thread safe (GT 2.2.x branch) and it causes java.util.ConcurrentModificationException

[Andrea Aime]

Vitali Diatchkov ha scritto:
> 
> Hello!
> 
> I have faced with a problem of concurrent modification of Filter that leads
> to exception throwing:

...

> This use case is coming from UDIG. 
> 
> Shouldn't all the Filter objects be immutable? (Just a quick mind). Or what
> does the Filter design say about Filter modifications and multi-threading
> issues?

They should be immutable IMHO... but the even the filter interfaces do 
allow for modification after the filter is built, and nothing is stated
in the javadoc.
In a perfect world filters should take their arguments during
construction and then be immbutable. Maybe in gt2 2.4 things are better,
how's the situation with the new Filter interfaces?

Cheers
Andrea