[udig-devel] Changes to Catalog on trunk; review of large commit

[Jody Garnett]

The related issues are:
- http://jira.codehaus.org/browse/UDIG-1105 Resolved - pending review of 
alternatives
- http://jira.codehaus.org/browse/UDIG-1107 Closed

I would like to know:
- any performance slowdown associated with more aggressive catalog.find 
method
- any performance speed up associated with more catalog.find paying 
attention to CONNECTED

There is one actual API code breakage:
- IService.getInfo( monitor ) was made abstract - chances are you 
implemented this one anyways


Here is a guide to the damage done ...
> M      
> net.refractions.udig.catalog.hsql\src\net\refractions\udig\catalog\hsql\internal\HsqlGeoResource.java
> M      
> net.refractions.udig.catalog.hsql\src\net\refractions\udig\catalog\hsql\internal\HsqlServiceImpl.java
IService.resolve / canResolve contract / also use monitor when connecting
> M      
> net.refractions.udig.catalog.shp\src\net\refractions\udig\catalog\internal\shp\ShpGeoResourceImpl.java
> M      
> net.refractions.udig.catalog.shp\src\net\refractions\udig\catalog\internal\shp\ShpServiceImpl.java
IService.resolve / canResolve contract / also use monitor when connecting
> M      
> net.refractions.udig.catalog\src\net\refractions\udig\catalog\IService.java
Change getInfo( monitor ) to abstract - scary change! And provide an 
implementation of resolve( class, monitor ) that delegates to IServer 
methods.
> M      
> net.refractions.udig.catalog\src\net\refractions\udig\catalog\memory\internal\MemoryServiceImpl.java
IService.resolve / canResolve contract.
> M      
> net.refractions.udig.catalog\src\net\refractions\udig\catalog\IResolve.java
Clean up javadocs with code example on how to use ResolveManager
> M      
> net.refractions.udig.catalog\src\net\refractions\udig\catalog\internal\CatalogImpl.java
fix up the find method to pay attention to CONNTECTED status; perform 
additional passes to look into services for stray georesources that do 
not follow our identification convention.
> M      
> net.refractions.udig.catalog\src\net\refractions\udig\catalog\util\GeoToolsAdapters.java
Actually tested now against a real GeoTools Service, ServiceInfo, 
GeoResource and GeoResourceInfo
> M      
> net.refractions.udig.catalog.arcsde\src\net\refractions\udig\catalog\internal\arcsde\ArcServiceImpl.java
> M      
> net.refractions.udig.catalog.arcsde\src\net\refractions\udig\catalog\internal\arcsde\ArcGeoResource.java
IService.resolve / canResolve contract / use monitor - note this still 
does not compile and is suffering bit rot.
> M      
> net.refractions.udig.catalog.tests\src\net\refractions\udig\catalog\tests\DummyMultiResourceService.java
> M      
> net.refractions.udig.catalog.tests\src\net\refractions\udig\catalog\tests\DummyService.java
> M      
> net.refractions.udig.catalog.tests\src\net\refractions\udig\catalog\tests\AbstractCatalogTest.java
IService.resolve / canResolve contract ....
> M      
> net.refractions.udig.catalog.oracle\src\net\refractions\udig\catalog\internal\oracle\OracleServiceImpl.java
> M      
> net.refractions.udig.catalog.oracle\src\net\refractions\udig\catalog\internal\oracle\OracleGeoResource.java
> M      
> net.refractions.udig.catalog.gml\src\net\refractions\udig\catalog\internal\gml\GMLServiceImpl.java
> M      
> net.refractions.udig.catalog.gml\src\net\refractions\udig\catalog\internal\gml\GMLGeoResourceImpl.java
IService.resolve / canResolve contract / use of monitor for getDS( 
monitor )
> M      
> net.refractions.udig.catalog.rasterings\src\net\refractions\udig\catalog\rasterings\AbstractRasterService.java
> M      
> net.refractions.udig.catalog.rasterings\src\net\refractions\udig\catalog\rasterings\AbstractRasterGeoResource.java
> M      org.ossim.catalog\src\org\ossim\catalog\OssimService.java
IService.resolve / canResolve contract
> M      
> net.refractions.udig.project\src\net\refractions\udig\project\internal\LayerDecorator.java
Infinite loop.
> M      
> net.refractions.udig.project\src\net\refractions\udig\project\internal\impl\LayerImpl.java
> M      
> net.refractions.udig.project\src\net\refractions\udig\project\internal\render\impl\RenderExecutorImpl.java
> M      
> net.refractions.udig.project\src\net\refractions\udig\project\internal\render\impl\RendererImpl.java
> M      
> net.refractions.udig.project\src\net\refractions\udig\project\render\IRenderMetricsFactory.java
> M      
> net.refractions.udig.project\src\net\refractions\udig\project\render\IRenderer.java
Javadocs.
> M      
> net.refractions.udig.project.tests\src\net\refractions\udig\project\internal\TestCatalogRef.java
> M      
> net.refractions.udig.mapgraphic\src\net\refractions\udig\mapgraphic\internal\MapGraphicService.java
> M      
> net.refractions.udig.catalog.wms\src\net\refractions\udig\catalog\internal\wms\WMSServiceImpl.java
> M      
> net.refractions.udig.catalog.db2\src\net\refractions\udig\catalog\internal\db2\DB2Service.java
> M      
> net.refractions.udig.catalog.db2\src\net\refractions\udig\catalog\internal\db2\DB2GeoResource.java
> M      
> net.refractions.udig.catalog.postgis\src\net\refractions\udig\catalog\internal\postgis\PostGISServiceImpl.java
> M      
> net.refractions.udig.catalog.wfs\src\net\refractions\udig\catalog\internal\wfs\WFSServiceImpl.java
> M      
> net.refractions.udig.catalog.wfs\src\net\refractions\udig\catalog\internal\wfs\WFSGeoResourceImpl.java
> M      
> net.refractions.udig.catalog.cgdi\src\net\refractions\udig\catalog\cgdi\CGDIService.java
IService.resolve / canResolve contract